President-elect Donald J. Trump has long seen his bombastic national security operative as a political “enforcer.” But former colleagues question his fitness for the job.